Skip to content

zlib: fix zstd reset - #65867

Open
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/zstd-reset
Open

zlib: fix zstd reset#65867
jasnell wants to merge 3 commits into
nodejs:mainfrom
jasnell:jasnell/zstd-reset

Conversation

@jasnell

@jasnell jasnell commented Sep 6, 2026

Copy link
Copy Markdown
Member

Handful of additional bits I noticed while poking around zstd..

  • Preserve dictionaries and params when zstd is reset.
  • Update missing documentation.
  • Reject invalid dictionaries (they would previously no-op)

The rejection is technically a behavior change but zstd is still experimental.

Preserve dictionaries and params when zstd is reset.

Update missing documentation.

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib module and its compression dependencies. labels Sep 6, 2026
@nodejs-github-bot

This comment was marked as outdated.

Signed-off-by: James M Snell <jsnell@cloudflare.com>
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 54.54545% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.20%. Comparing base (8af7545) to head (5c17be7).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/node_zlib.cc 46.42% 11 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65867      +/-   ##
==========================================
+ Coverage   90.18%   90.20%   +0.01%     
==========================================
  Files         771      771              
  Lines      264619   264660      +41     
  Branches    50231    50246      +15     
==========================================
+ Hits       238653   238736      +83     
+ Misses      16961    16918      -43     
- Partials     9005     9006       +1     
Files with missing lines Coverage Δ
lib/zlib.js 98.41% <100.00%> (+0.27%) ⬆️
src/node_zlib.cc 79.00% <46.42%> (-0.19%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib module and its compression dependencies.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants