lib: use Web IDL interface brand checks - #65846
Open
panva wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
panva
added
the
web-standards
Use explicit brand predicates for interface conversion instead of prototype ancestry. Update CryptoKey and AbortSignal together with the shared converter contract. Read internal AbortSignal state during composition. Preserve genuine signals after prototype changes without invoking shadowed getters. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: GitHub Copilot
panva
force-pushed
the
webidl-interface-brand-checks
branch
from
September 6, 2026 09:37
658c888 to
98a7ff5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65846 +/- ##
==========================================
+ Coverage 90.19% 90.20% +0.01%
==========================================
Files 771 771
Lines 264622 264623 +1
Branches 50223 50232 +9
==========================================
+ Hits 238663 238710 +47
+ Misses 16965 16896 -69
- Partials 8994 9017 +23
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Sep 6, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use explicit brand predicates for interface conversion instead of prototype ancestry. Update CryptoKey and AbortSignal together with the shared converter contract.
Read internal AbortSignal state during composition. Preserve genuine signals after prototype changes without invoking shadowed getters.
cc @nodejs/web-standards