typings: wire up quic internal binding types - #65839
Closed
sjungwon03 wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
the
typings
Import the existing QuicBinding declaration and add it to
InternalBindingMap so internalBinding('quic') uses the declared
binding type.
Assisted-by: Codex
Signed-off-by: sjungwon03 <sjungwon03@gmail.com>
sjungwon03
force-pushed
the
sjungwon03/typings-wire-quic-binding
branch
from
September 6, 2026 07:48
59e1c6e to
98c15b2
Compare
Contributor
Author
|
Closing this as a duplicate of #65556. I missed the existing PR before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typings/internalBinding/quic.d.tsalready definesQuicBinding, but the declaration is not connected to the globalInternalBindingMap.Import
QuicBindingintypings/globals.d.tsand register thequicbinding so calls tointernalBinding('quic')use the existing type declaration.