src,lib: add util.markPromiseAsHandled - #65805
Open
jasnell wants to merge 2 commits into
Open
Conversation
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
jasnell/promise-mark-promise-as-handled
branch
from
September 5, 2026 02:55
a784a8f to
d8a9ada
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65805 +/- ##
==========================================
+ Coverage 90.14% 90.18% +0.03%
==========================================
Files 769 771 +2
Lines 262968 264636 +1668
Branches 50052 50231 +179
==========================================
+ Hits 237049 238658 +1609
- Misses 16924 16967 +43
- Partials 8995 9011 +16
🚀 New features to boost your workflow:
|
mcollina
approved these changes
Sep 5, 2026
mcollina
left a comment
Member
There was a problem hiding this comment.
LGTM!
Probably the better perf utility
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
MoLow
approved these changes
Sep 6, 2026
LiviaMedeiros
left a comment
Member
There was a problem hiding this comment.
LGTM with the test fix.
Co-authored-by: Livia Medeiros <livia@cirno.name>
Collaborator
LiviaMedeiros
approved these changes
Sep 6, 2026
LiviaMedeiros
left a comment
Member
There was a problem hiding this comment.
Maybe we should also update the suggestion here?
Lines 474 to 479 in 10720f7
LGTM whether it's updated in this PR or as follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting tired of seeing
promise.catch(() => {})in places ;-)