stream: fix merge handling for object-like sources#63356
Open
trivikr wants to merge 2 commits into
Open
Conversation
merge() treated any final non-iterable object as an options object. That dropped valid from() inputs such as ArrayBuffer, ArrayBufferView, and streamable protocol objects. Fixes: nodejs#63355 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
jasnell
approved these changes
May 15, 2026
Renegade334
reviewed
May 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63356 +/- ##
==========================================
- Coverage 90.06% 90.05% -0.01%
==========================================
Files 714 714
Lines 225502 225524 +22
Branches 42628 42639 +11
==========================================
+ Hits 203089 203090 +1
- Misses 14195 14218 +23
+ Partials 8218 8216 -2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge()previously treated any final non-iterable object as an optionsobject, which dropped valid inputs that
from()accepts, includingArrayBuffer,ArrayBufferView, and objects implementingStream.toStreamableorStream.toAsyncStreamable.This updates the options-object heuristic to preserve those valid source
types and adds regression coverage for the affected cases.
Fixes: #63355
Assisted-by: openai:gpt-5.5