Skip to content

test: fix compiler warnings in test_node_crypto.cc #63341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpatankar6 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −16
Open

test: fix compiler warnings in test_node_crypto.cc #63341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions test/cctest/test_node_crypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
#define NODE_OPENSSL_SYSTEM_CERT_PATH "/missing/ca.pem"

#include "crypto/crypto_context.h"
#include "gtest/gtest.h"
#include "node_options.h"
#include "openssl/err.h"
#include "gtest/gtest.h"

/*
* This test verifies that a call to NewRootCertDir with the build time
Expand All @@ -28,23 +28,18 @@ TEST(NodeCrypto, NewRootCertStore) {
*/
TEST(NodeCrypto, MemoryTrackingConstants) {
// Verify that our memory tracking constants are defined and reasonable
EXPECT_GT(node::crypto::kSizeOf_SSL_CTX, 0)
<< "SSL_CTX size constant should be positive";
EXPECT_GT(node::crypto::kSizeOf_X509, 0)
<< "X509 size constant should be positive";
EXPECT_GT(node::crypto::kSizeOf_EVP_MD_CTX, 0)
<< "EVP_MD_CTX size constant should be positive";
EXPECT_GT(node::crypto::kSizeOf_SSL_CTX, 0UL)
<< "SSL_CTX size constant should be greater than 0";
EXPECT_GT(node::crypto::kSizeOf_X509, 0UL)
<< "X509 size constant should be greater than 0";
EXPECT_GT(node::crypto::kSizeOf_EVP_MD_CTX, 0UL)
<< "EVP_MD_CTX size constant should be greater than 0";

// Verify reasonable size ranges (basic sanity check)
EXPECT_LT(node::crypto::kSizeOf_SSL_CTX, 10000)
// Verify reasonable upper bounds in case of overflow (basic sanity check)
EXPECT_LT(node::crypto::kSizeOf_SSL_CTX, 1000UL)
<< "SSL_CTX size should be reasonable";
EXPECT_LT(node::crypto::kSizeOf_X509, 10000)
EXPECT_LT(node::crypto::kSizeOf_X509, 1000UL)
<< "X509 size should be reasonable";
EXPECT_LT(node::crypto::kSizeOf_EVP_MD_CTX, 1000)
EXPECT_LT(node::crypto::kSizeOf_EVP_MD_CTX, 1000UL)
<< "EVP_MD_CTX size should be reasonable";

// Specific values we expect based on our implementation
EXPECT_EQ(node::crypto::kSizeOf_SSL_CTX, 240);
EXPECT_EQ(node::crypto::kSizeOf_X509, 128);
EXPECT_EQ(node::crypto::kSizeOf_EVP_MD_CTX, 48);
}
Loading