Skip to content

chore: replace shrinkwrap with package lock - #152

Merged
aduh95 merged 3 commits into
nodejs:mainfrom
trivikr:remove-npm-shrinkwrap
Sep 2, 2026
Merged

chore: replace shrinkwrap with package lock#152
aduh95 merged 3 commits into
nodejs:mainfrom
trivikr:remove-npm-shrinkwrap

Conversation

@trivikr

@trivikr trivikr commented Aug 28, 2026

Copy link
Copy Markdown
Member

npm-shrinkwrap.json was added in #134 to pin the transitive dependencies of gitlint-parser-node.

Since #144 moved that package into this repository, the only remaining runtime dependency is the dependency-free gitlint-parser-base whose last publish was in 2016.

This PR:

  • Pins gitlint-parser-base to 2.0.0.
  • Replaces the published shrinkwrap with a development-only package-lock.json.
  • Avoids publishing dev-dependency metadata.

This will be required to work with npm 12, which has removed support for npm-shrinkwrap.json.


Assisted-by: codex:gpt-5.6-sol

@trivikr

trivikr commented Aug 30, 2026

Copy link
Copy Markdown
Member Author

cc @aduh95 for review, as he'd pinned the dependencies in #134 back in 2021.

@trivikr

trivikr commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

cc @panva Can you review this?

Comment thread package.json Outdated
@trivikr
trivikr requested a review from aduh95 September 1, 2026 23:36
Comment thread package.json Outdated
Comment thread package.json Outdated
@trivikr
trivikr requested a review from aduh95 September 2, 2026 07:39
@aduh95
aduh95 merged commit 5417712 into nodejs:main Sep 2, 2026
4 checks passed
@trivikr
trivikr deleted the remove-npm-shrinkwrap branch September 2, 2026 16:40
@trivikr

trivikr commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

Thank you, @aduh95, for the merge.

When can we publish this change?
I think it should be v6.1.0 since this package no longer publishes devDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants