Skip to content

chore: replace gitexec with node:child_process.spawn - #290

Open
trivikr wants to merge 4 commits into
nodejs:mainfrom
trivikr:replace-gitexec
Open

chore: replace gitexec with node:child_process.spawn#290
trivikr wants to merge 4 commits into
nodejs:mainfrom
trivikr:replace-gitexec

Conversation

@trivikr

@trivikr trivikr commented Nov 3, 2026

Copy link
Copy Markdown
Member

Removes the gitexec dependency (and its bl dependency tree) by running git log with node:child_process.spawn directly.

Behavior is unchanged:

  • Output is still streamed line by line via readline, so large histories (--all) aren't buffered in memory.
  • git's stderr goes straight to the terminal.
  • A non-zero git exit throws the same error message as before.

@trivikr
chore: replace gitexec with node:child_process.spawn
f5ca3b8
@trivikr
fix: avoid unhandled rejection when git process errors
ecd07af 
Await the child 'close' event together with the pipeline so a spawn
error after a pipeline failure is handled.
@trivikr
fix: treat git process killed by signal as failure
16ed473 
When the child is terminated by a signal, 'close' reports a null exit
code, which was previously treated as success and could return a
truncated commit list. Check the signal as well.
@trivikr

trivikr commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

cc @rvagg

aduh95
aduh95 reviewed Nov 13, 2026
View reviewed changes
Comment thread commit-to-list.js Resolved
@trivikr
trivikr requested a review from aduh95 November 13, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trivikr @aduh95