Skip to content

fix: close quote and drop empty group in plaintext reverts - #289

Merged
rvagg merged 1 commit into
nodejs:mainfrom
trivikr:plaintext-reverts
Nov 3, 2026
Merged

rvagg merged 1 commit into
nodejs:mainfrom
trivikr:plaintext-reverts

Conversation

@trivikr

@trivikr trivikr commented Nov 2, 2026

Copy link
Copy Markdown
Member

toStringPlaintext printed reverts with no closing quote, and printed a leading ": when the commit had no group:

  * Revert "fs: fix thing (A) https://github.com/nodejs/node/pull/1
  * Revert ": fix thing (A)

This PR adds the group prefix only when a group exists, matching the simple and markdown formats, and closes the quote:

  * Revert "fs: fix thing" (A) https://github.com/nodejs/node/pull/1
  * Revert "fix thing" (A)

@rvagg
rvagg merged commit 56ddb4a into nodejs:main Nov 3, 2026
5 checks passed
github-actions Bot pushed a commit that referenced this pull request Nov 3, 2026
## [5.1.1](v5.1.0...v5.1.1) (2026-11-03)

### Bug Fixes

* close quote and drop empty group in plaintext reverts ([#289](#289)) ([56ddb4a](56ddb4a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants