fix: handle mappers without __name__ in extract_etree error path#253
Open
Flerpharos wants to merge 1 commit into
Open
fix: handle mappers without __name__ in extract_etree error path#253Flerpharos wants to merge 1 commit into
Flerpharos wants to merge 1 commit into
Conversation
extract_etree accepts any Callable mapper, but its ValueError handler formats mapper.__name__. Valid callables such as functools.partial and callable class instances do not necessarily have __name__, so the error path raises AttributeError and masks the original parse failure instead of raising ExtractionError. Fix by using getattr with a repr fallback. Closes #213
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_etreeaccepts anyCallablemapper, but itsValueErrorhandler formatsmapper.__name__. Valid callables such asfunctools.partialand callable class instances do not necessarily have__name__, so the error path raisesAttributeErrorand masks the original parse failure instead of raisingExtractionError.Fix
Use
getattr(mapper, "__name__", repr(mapper))so that it falls back torepr()if the__name__attribute does not exist.Closes #213