Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
# NOTE - this doesn't currently work if the PR is coming from a fork, due to limitations in GitHub actions secrets
- name: Post PR comment
if: failure()
uses: mshick/add-pr-comment@8e4927817251f1ff60c001f04568532b38e0b4a0 # v3
uses: mshick/add-pr-comment@b8f338c590a895d50bcbfa6c5859251edc8952fc # v2
with:
message: |
## This PR is against the `${{github.event.pull_request.base.ref}}` branch :x:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/linting_comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Download lint results
uses: dawidd6/action-download-artifact@b6e2e70617bc3265edd6dab6c906732b2f1ae151 # v21
uses: dawidd6/action-download-artifact@ac66b43f0e6a346234dd65d4d0c8fbb31cb316e5 # v11
with:
workflow: linting.yml
workflow_conclusion: completed
Expand All @@ -21,7 +21,7 @@ jobs:
run: echo "pr_number=$(cat linting-logs/PR_number.txt)" >> $GITHUB_OUTPUT

- name: Post PR comment
uses: marocchino/sticky-pull-request-comment@70d2764d1a7d5d9560b100cbea0077fc8f633987 # v3
uses: marocchino/sticky-pull-request-comment@773744901bac0e8cbb5a0dc842800d45e9b2b405 # v2
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
number: ${{ steps.pr_number.outputs.pr_number }}
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### `Changes`

1. Changed from `delly_call` to `delly_sr`. Delly v2.6.0
2. Removed the SV type parallelization (`--svtype`) and `BCFTOOLS_CONCAT` from the delly flow. Delly v2 parallelizes within a single run via `--threads`, and writes BCFs without a sample column for SV types that yield no calls, which `bcftools concat` rejects.

### `Fixed`

1. Added threading to the `EXPANSIONHUNTER` process
Expand Down
10 changes: 2 additions & 8 deletions conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,8 @@ process {
// Delly
//

withName: "^.*BAM_VARIANT_CALLING_DELLY:DELLY_CALL\$" {
tag = { "${meta.id}.${meta.sv_type}" }
ext.args = {"--svtype ${meta.sv_type} --map-qual ${params.delly_map_qual} --min-clique-size ${params.delly_min_clique_size}"}
ext.prefix = { "${meta.id}.${meta.sv_type}" }
}

withName: "^.*BAM_VARIANT_CALLING_DELLY:BCFTOOLS_CONCAT\$" {
ext.args = "--output-type z --allow-overlaps"
withName: "^.*BAM_VARIANT_CALLING_DELLY:DELLY_SR\$" {
ext.args = {"--map-qual ${params.delly_map_qual} --min-clique-size ${params.delly_min_clique_size}"}
}

withName: "^.*BAM_VARIANT_CALLING_DELLY:BCFTOOLS_SORT\$" {
Expand Down
1 change: 1 addition & 0 deletions docs/CITATIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
- [DELLY](https://academic.oup.com/bioinformatics/article/28/18/i333/245403)

> Tobias Rausch, Thomas Zichner, Andreas Schlattl, Adrian M. Stütz, Vladimir Benes, Jan O. Korbel, DELLY: structural variant discovery by integrated paired-end and split-read analysis, Bioinformatics, Volume 28, Issue 18, September 2012, Pages i333–i339, https://doi.org/10.1093/bioinformatics/bts378
> Now using Delly v2.6.0

- [EnsemblVEP](https://pubmed.ncbi.nlm.nih.gov/27268795/)

Expand Down
4 changes: 2 additions & 2 deletions modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@
"git_sha": "5cb9a8694da0a0e550921636bb60bc8c56445fd7",
"installed_by": ["modules"]
},
"delly/call": {
"delly/sr": {
"branch": "master",
"git_sha": "fdcc3976e728b5d6ffc3f15979905829531e6072",
"git_sha": "6b87364d2e54b9136e0e57de28bd56b5010d47ff",
"installed_by": ["modules"]
},
"ensemblvep/download": {
Expand Down
5 changes: 0 additions & 5 deletions modules/nf-core/delly/call/tests/vcf.config

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading