Skip to content

Task notes - fix opening URLs in new window#3193

Open
4oo4 wants to merge 1 commit into
nextcloud:mainfrom
4oo4:main
Open

Task notes - fix opening URLs in new window#3193
4oo4 wants to merge 1 commit into
nextcloud:mainfrom
4oo4:main

Conversation

@4oo4

@4oo4 4oo4 commented Jul 3, 2026

Copy link
Copy Markdown

Add the target="_blank" back to the <a> that is stripped out by DOMPurify. Set rel="nofollow noopener noreferrer" to harden against reverse tabnabbing.

I just saw the DCO real name requirement after opening the PR, if this isn't considered trivial feel free to close and have a maintainer recommit.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI.

I used Claude Opus 4.8 (chat, not Claude Code) to help me find why the target was being stripped out, and it suggested the additional rel hardening.

Add the target="_blank" back to the <a> that is stripped out by DOMPurify. Set rel="nofollow noopener noreferrer" to harden against reverse tabnabbing

Signed-off-by: 4oo4 <4oo4@users.noreply.github.com>
Assisted-by: Claude:claude-opus-4-8
@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant