Potential fix for code scanning alert no. 2: Uncontrolled data used in path expression - #51
Draft
jimklimov wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 2: Uncontrolled data used in path expression#51jimklimov wants to merge 1 commit into
jimklimov wants to merge 1 commit into
Conversation
…n path expression Validate the `dir` value more diligently. Frown upon relative paths going through `..`. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| dir = null; | ||
| } else { | ||
| File candidate = new File(localExecPath).getCanonicalFile(); | ||
| if (candidate.exists() && candidate.isDirectory()) { |
| dir = null; | ||
| } else { | ||
| File candidate = new File(localExecPath).getCanonicalFile(); | ||
| if (candidate.exists() && candidate.isDirectory()) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/networkupstools/jNut/security/code-scanning/2
General fix approach: enforce strict validation at the sink boundary (where the path is consumed) so only safe working directories are accepted. Relying on callers to always sanitize is fragile, especially with a generic
setParamAPI.Best fix here: in
jNut/src/main/java/org/networkupstools/jnut/Scanner.java, validatelocalExecPathinscan()before creating/usingFile dir. Reject path traversal patterns (..), and require a canonical existing directory. If validation fails, ignore the provided path and fall back toruntime.exec(params)(current behavior whendir == null), preserving functionality while removing unsafe path usage. No behavior change for valid configured paths.Concretely:
scan()block around current lines 330–334.getCanonicalFile()), reject values containing.., and ensure directory exists/isDirectory.IOExceptionfrom canonicalization and treat as invalid (dir = null).java.io.*imports already cover required classes.Suggested fixes powered by Copilot Autofix. Review carefully before merging.