Skip to content

ci: use pnpm/action-setup on Windows for e2e tests#8256

Open
serhalp wants to merge 1 commit into
mainfrom
claude/slack-session-iYgke
Open

ci: use pnpm/action-setup on Windows for e2e tests#8256
serhalp wants to merge 1 commit into
mainfrom
claude/slack-session-iYgke

Conversation

@serhalp
Copy link
Copy Markdown
Member

@serhalp serhalp commented May 13, 2026

Summary

Corepack on Windows wasn't properly respecting the npm_config_registry environment variable when running pnpm commands, causing E2E tests to fail with "No matching version found for netlify-cli@testing" because pnpm was fetching from npmjs.org instead of the local Verdaccio server.

The e2e tests for pnpm were implicitly using whatever happened to be the latest pnpm. pnpm@11 was recently released and broke some assumption somewhere.

This removes the weird Windows exception.

Corepack on Windows wasn't properly respecting the npm_config_registry
environment variable when running pnpm commands, causing E2E tests to
fail with "No matching version found for netlify-cli@testing" because
pnpm was fetching from npmjs.org instead of the local Verdaccio server.

Using pnpm/action-setup@v4 on all platforms ensures consistent pnpm
behavior and proper registry configuration.

https://claude.ai/code/session_016BxeLefKMryvxZnuzBbxVD
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

The E2E workflow consolidates pnpm package manager setup by replacing prior conditional Windows/non-Windows initialization steps with a single unified "Setup pnpm" step, while retaining the downstream pnpm/action-setup@v4 action configured for pnpm version 10.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: switching to pnpm/action-setup on Windows for e2e tests to fix registry configuration issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly explains the problem (Corepack not respecting npm_config_registry on Windows), the impact (E2E test failures), and the solution (removing Windows exception and using pnpm/action-setup consistently).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/slack-session-iYgke

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

📊 Benchmark results

Comparing with 0a70cf4

  • Dependency count: 1,129 (no change)
  • Package size: 379 MB (no change)
  • Number of ts-expect-error directives: 355 (no change)

@serhalp serhalp changed the title fix(ci): use pnpm/action-setup on Windows for E2E tests ci: use pnpm/action-setup on Windows for e2e tests May 13, 2026
@serhalp serhalp marked this pull request as ready for review May 13, 2026 22:29
@serhalp serhalp requested a review from a team as a code owner May 13, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants