ci: use pnpm/action-setup on Windows for e2e tests#8256
Open
serhalp wants to merge 1 commit into
Open
Conversation
Corepack on Windows wasn't properly respecting the npm_config_registry environment variable when running pnpm commands, causing E2E tests to fail with "No matching version found for netlify-cli@testing" because pnpm was fetching from npmjs.org instead of the local Verdaccio server. Using pnpm/action-setup@v4 on all platforms ensures consistent pnpm behavior and proper registry configuration. https://claude.ai/code/session_016BxeLefKMryvxZnuzBbxVD
Contributor
📝 WalkthroughWalkthroughThe E2E workflow consolidates pnpm package manager setup by replacing prior conditional Windows/non-Windows initialization steps with a single unified "Setup pnpm" step, while retaining the downstream Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Benchmark resultsComparing with 0a70cf4
|
pnpm/action-setup on Windows for e2e tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corepack on Windows wasn't properly respecting the npm_config_registry environment variable when running pnpm commands, causing E2E tests to fail with "No matching version found for netlify-cli@testing" because pnpm was fetching from npmjs.org instead of the local Verdaccio server.
The e2e tests for pnpm were implicitly using whatever happened to be the latest pnpm. pnpm@11 was recently released and broke some assumption somewhere.
This removes the weird Windows exception.