Bug forcing tag naming strategy with prefix v

[bueno-felipe]

From version 18.0.6 and so on the NearestVersionLocator only read tags that use v as prefix, as you can see in this commit:
7d369f6

https://github.com/nebula-plugins/nebula-release-plugin/blame/c3850c0a954fafce9064c94ad1c47a58f94381fd/src/main/groovy/nebula/plugin/release/git/command/GitReadCommand.groovy#L115

But the base plugin gradle-git allow users to extend the tagStrategy to define how the git tag will be created, through setting:

#build.gradle
release {
    tagStrategy {
       prefixNameWithV = false
    }
}

or

#build.gradle
release {
    tagStrategy {
       toTagString = { version -> "${version}" }
    }  
}

Shouldn't it to be consider as a bug?

[bueno-felipe]

This issue could be related: #221

[theborakompanioni]

Ran into this issue today. Workaround is to explicitly define -Prelease.version. Any possibility this can be taken a closer look? 🙏

[bueno-felipe]

@theborakompanioni My workaround to fix it was to downgrade to version 18.0.5, which was the last version without this issue. Explicitly defining -Prelease.version kind of misses the purpose of using this library.

[davidjlynn]

Also hitting this, so created a reproduction.

davidjlynn/example-api-nebula-issue-reproduction#1 was ran with tags of the format vx.y.z. This resulted in tag 0.2.0-dev.3+e5131fb.

I then retagged the repository to the format vx.y.z -> x.y.z

Then davidjlynn/example-api-nebula-issue-reproduction#2 showed that the build number was calcualted incorrectly to 0.1.0-dev.17+2268f04

A note that these are all lightweight tags in the reproduction.

[davidjlynn]

@rpalcolea / @OdysseusLives is this an acceptable issue? Or is there some other background why we wouldn't want to fix this?

If acceptable, could I request #283 be reviewed?

[davidjlynn]

@rpalcolea / @OdysseusLives would you be able to give this a review and trigger the verification builds?
As a first time contributor to this repository I am unable to formally add reviewers on the PR unfortunately, so trying here.
Thank you.

[davidjlynn]

Hi @OdysseusLives / @rpalcolea , could I request a release be made to include this bug fix?
Thank you