Specify Rust edition in Cargo manifests - #247
Open
cepetr wants to merge 1 commit into
Open
Conversation
cepetr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifests of both Rust crates (
rust/Cargo.tomlandrust-no-heap/Cargo.toml) don't specifypackage.edition. For projects that consume these crates as a path dependency (e.g. via a git submodule), recent versions of Cargo emit this warning on every build:This PR adds
edition = "2015"to the[package]section of both manifests. This makes the current implicit default explicit and silences the warning, with no change to how the code compiles. (Upgrading to a newer edition could be done separately, but that would need a review of the code under the new edition's semantics, so this PR deliberately stickswith 2015.)
We consume the no-heap crate in trezor/trezor-firmware as a git submodule and would be happy to see this fixed upstream.
Thanks for the great library!