MenuView: fix x/y properties

[cbjeukendrup]

Don’t override them immediately after setting them, in updateGeometry. Instead, set them in QML, and only when no explicit value for them is requested, hoping that this preserve the intention of the removed code (I must admit I’m not 100% sure what the intention was).

Also remove seemingly redundant calls to updateGeometry (but removing just those calls does not solve the problem).

[cbjeukendrup]

@mathesoncalum Kind reminder about this PR. The best way to see what it fixes, is testing musescore/MuseScore#33301, first without and then with this framework change.

[coderabbitai]

Warning

Review limit reached

@cbjeukendrup, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 36281e5d-5b80-4589-aff7-adc4e847342f

📥 Commits

Reviewing files that changed from the base of the PR and between 5a32488 and 66f83eb.

📒 Files selected for processing (2)

• framework/uicomponents/qml/Muse/UiComponents/StyledMenuLoader.qml
• framework/uicomponents/qml/Muse/UiComponents/menuview.cpp

📝 Walkthrough

Walkthrough

This change adjusts menu positioning behavior. StyledMenuLoader.qml now resets menu.x to 0 for an x sentinel of -1 and binds menu.y to the parent height for a y sentinel of -1. menuview.cpp removes the defer.h include, local position assignments in updateGeometry(), and queued updateGeometry() calls before repositionWindowIfNeed().

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is too incomplete for the template; it lacks the required issue reference and checklist sections.	Add the Resolves line, a short motivation, and complete the required checklist items, including testing and CLA acknowledgment.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: fixing MenuView x/y property handling.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[mathesoncalum]

/build

[github-actions]

Build dispatched: https://github.com/musescore/muse_framework/actions/runs/28778902981

[cbjeukendrup]

@mathesoncalum What is the next step for this PR?