Skip to content

fix(dockwindow_v2): add missing include - #162

Merged
RomanPudashkin merged 1 commit into
musescore:mainfrom
cbjeukendrup:dockwindow_v2/fix-build
Jul 22, 2026
Merged

fix(dockwindow_v2): add missing include#162
RomanPudashkin merged 1 commit into
musescore:mainfrom
cbjeukendrup:dockwindow_v2/fix-build

Conversation

@cbjeukendrup

Copy link
Copy Markdown
Contributor

Otherwise:

/Users/casper/Desktop/MuseScore/MuseScoreGB/muse/framework/dockwindow_v2/internal/dropcontroller.cpp:128:13: error: no matching function for call to 'asQQuickItem'
  128 |             KDDockWidgets::QtQuick::asQQuickItem(dw));
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/casper/Desktop/MuseScore/MuseScoreGB/build/Qt_6_11_1_for_macOS-DebugNonUnity/_deps/kddockwidgets/kddockwidgets/src/qtquick/views/View.h:34:20: note: candidate function not viable: cannot convert argument of incomplete type 'KDDockWidgets::Core::DockWidget *' to 'Core::View *' for 1st argument
   34 | inline QQuickItem *asQQuickItem(Core::View *view)
      |                    ^            ~~~~~~~~~~~~~~~~
/Users/casper/Desktop/MuseScore/MuseScoreGB/build/Qt_6_11_1_for_macOS-DebugNonUnity/_deps/kddockwidgets/kddockwidgets/src/qtquick/views/View.h:42:20: note: candidate function not viable: cannot convert argument of incomplete type 'KDDockWidgets::Core::DockWidget *' to 'Core::Controller *' for 1st argument
   42 | inline QQuickItem *asQQuickItem(Core::Controller *controller)
      |                    ^            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Otherwise:
```
/Users/casper/Desktop/MuseScore/MuseScoreGB/muse/framework/dockwindow_v2/internal/dropcontroller.cpp:128:13: error: no matching function for call to 'asQQuickItem'
  128 |             KDDockWidgets::QtQuick::asQQuickItem(dw));
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/casper/Desktop/MuseScore/MuseScoreGB/build/Qt_6_11_1_for_macOS-DebugNonUnity/_deps/kddockwidgets/kddockwidgets/src/qtquick/views/View.h:34:20: note: candidate function not viable: cannot convert argument of incomplete type 'KDDockWidgets::Core::DockWidget *' to 'Core::View *' for 1st argument
   34 | inline QQuickItem *asQQuickItem(Core::View *view)
      |                    ^            ~~~~~~~~~~~~~~~~
/Users/casper/Desktop/MuseScore/MuseScoreGB/build/Qt_6_11_1_for_macOS-DebugNonUnity/_deps/kddockwidgets/kddockwidgets/src/qtquick/views/View.h:42:20: note: candidate function not viable: cannot convert argument of incomplete type 'KDDockWidgets::Core::DockWidget *' to 'Core::Controller *' for 1st argument
   42 | inline QQuickItem *asQQuickItem(Core::Controller *controller)
      |                    ^            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

```
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: bd33ba92-f8cc-4f9a-a633-eb960ffb9b33

📥 Commits

Reviewing files that changed from the base of the PR and between 96f753f and 3f30b57.

📒 Files selected for processing (1)
  • framework/dockwindow_v2/internal/dropcontroller.cpp

📝 Walkthrough

Walkthrough

Added a direct include for kddockwidgets/src/core/DockWidget.h in dropcontroller.cpp. No functional logic or public declarations changed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description does not follow the required template and is missing the issue link, summary, and checklist items. Add the required template sections: issue reference, short motivation summary, and all checklist items with accurate completion.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a missing include to fix dockwindow_v2.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RomanPudashkin
RomanPudashkin merged commit d4611e4 into musescore:main Jul 22, 2026
3 checks passed
@cbjeukendrup
cbjeukendrup deleted the dockwindow_v2/fix-build branch July 22, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants