[Jojo-Schmitz]

Resolves: #34229
Backport of #34242

[coderabbitai]

📝 Walkthrough

Walkthrough

Extended Note::noteHead pitch-name scheme handling for TPCs representing double and triple accidentals. These values now select the corresponding natural notehead groups for degrees A–G, with German notation retaining its special handling for B-related degrees.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only lists the issue and backport; it omits the required summary and checklist items from the template.	Add a short change summary and complete the template checklist items, including CLA, testing, and unnecessary-changes review.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the bug fix and matches the pitch-name notehead fallback change.
Linked Issues check	✅ Passed	The code change matches #34229 by handling unsupported pitch-name noteheads and preserving German special-casing.
Out of Scope Changes check	✅ Passed	The change is confined to note.cpp and aligns with the stated pitch-name notehead fallback fix.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/engraving/dom/note.cpp (1)

468-499: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider using a switch statement for TPC mapping.

The if-else if chain for mapping TPCs to notehead groups has grown quite large. Converting the entire block (lines 351-500) into a switch (tpc) statement would improve readability and slightly improve execution performance.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/engraving/dom/note.cpp` around lines 468 - 499, Convert the complete
TPC-to-notehead-group mapping block in the surrounding notehead-group selection
function into a switch statement on tpc. Add cases for each existing Tpc value,
preserve the german-specific B/B-sharp handling and all current group
assignments, and retain the existing fallback behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/engraving/dom/note.cpp`:
- Around line 488-489: Update the TPC_B_BB and TPC_B_BBB branch in the note-head
grouping logic to assign NoteHeadGroup::HEAD_H instead of HEAD_B, matching the
German notation fallback used for TPC_B_SS.

---

Nitpick comments:
In `@src/engraving/dom/note.cpp`:
- Around line 468-499: Convert the complete TPC-to-notehead-group mapping block
in the surrounding notehead-group selection function into a switch statement on
tpc. Add cases for each existing Tpc value, preserve the german-specific
B/B-sharp handling and all current group assignments, and retain the existing
fallback behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d47a9daf-3cbf-4cfb-921a-3013070c5fe9

📥 Commits

Reviewing files that changed from the base of the PR and between 4d3e04e and 1f8a0d62bb2bffdea9972da2fa59830672469224.

📒 Files selected for processing (1)

• src/engraving/dom/note.cpp

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Handle German notation for B double/triple flats.

In German notation, B double flat is "Heses", which derives from the base note "H" (B natural). When stripping accidentals for these unsupported TPCs, the group should fall back to HEAD_H instead of HEAD_B. The current code maps to HEAD_B unconditionally, which is inconsistent with the handling of TPC_B_SS on lines 470-475.

🐛 Proposed fix

-        } else if (tpc == Tpc::TPC_B_BB || tpc == Tpc::TPC_B_BBB) {
-            group = NoteHeadGroup::HEAD_B;
+        } else if (tpc == Tpc::TPC_B_BB || tpc == Tpc::TPC_B_BBB) {
+            if (german) {
+                group = NoteHeadGroup::HEAD_H;
+            } else {
+                group = NoteHeadGroup::HEAD_B;
+            }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	} else if (tpc == Tpc::TPC_B_BB || tpc == Tpc::TPC_B_BBB) {
	group = NoteHeadGroup::HEAD_B;
	} else if (tpc == Tpc::TPC_B_BB || tpc == Tpc::TPC_B_BBB) {
	if (german) {
	group = NoteHeadGroup::HEAD_H;
	} else {
	group = NoteHeadGroup::HEAD_B;
	}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/engraving/dom/note.cpp` around lines 488 - 489, Update the TPC_B_BB and
TPC_B_BBB branch in the note-head grouping logic to assign NoteHeadGroup::HEAD_H
instead of HEAD_B, matching the German notation fallback used for TPC_B_SS.

[Jojo-Schmitz]

Right you are! Will get fixed in #34245 and #34242