[DockWindow v2] CI. Enabled KDDockWidgets v2 by default

[Eism]

After fixing critical bugs, I think we are ready to move to v2

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c03e1aa4-fd27-4cff-9482-4cb8288fc97b

📥 Commits

Reviewing files that changed from the base of the PR and between 8fc2acb and b2afd01.

📒 Files selected for processing (6)

• .github/workflows/build_all.yml
• .github/workflows/build_linux.yml
• .github/workflows/build_macos.yml
• .github/workflows/build_windows.yml
• CMakeLists.txt
• ninja_build.sh

🚧 Files skipped from review as they are similar to previous changes (5)

• ninja_build.sh
• CMakeLists.txt
• .github/workflows/build_windows.yml
• .github/workflows/build_all.yml
• .github/workflows/build_linux.yml

---

📝 Walkthrough

Walkthrough

Updated the dockwidgets_v2 default from OFF to ON for manual and reusable workflow inputs across the build-all, Linux, macOS, and Windows workflows. Enabled the dockwidgets_v2 CMake module and updated the muse subproject reference to a new commit.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is far too brief and omits the required issue reference, checklist, and testing details from the template.	Add the issue reference, a short motivation, and complete the template checklist items, including CLA, testing, and any notes on prior attempts or omitted changes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the main change: enabling KDDockWidgets v2 by default in CI.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CMakeLists.txt`:
- Line 195: Update the MUSE_MODULE_DOCKWINDOW_KDDOCKWIDGETS_V2 setting so it
defaults to ON only when the variable is not already defined, preserving
explicit OFF values passed by ninja_build.sh. Use a NOT DEFINED guard or an
equivalent cache default around this setting.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 690ca906-6ab5-4c2d-a64f-67b011771904

📥 Commits

Reviewing files that changed from the base of the PR and between 7299c85 and d96d4d1.

📒 Files selected for processing (6)

• .github/workflows/build_all.yml
• .github/workflows/build_linux.yml
• .github/workflows/build_macos.yml
• .github/workflows/build_windows.yml
• CMakeLists.txt
• muse

🚧 Files skipped from review as they are similar to previous changes (4)

• muse
• .github/workflows/build_all.yml
• .github/workflows/build_windows.yml
• .github/workflows/build_macos.yml

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CMakeLists.txt`:
- Around line 196-198: Update the MUSE_MODULE_DOCKWINDOW_KDDOCKWIDGETS_V2
initialization block to set the default only when the variable is undefined,
using CMake’s defined-variable check. Preserve explicitly supplied ON and OFF
values, including those forwarded by ninja_build.sh.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4c611011-a9ff-41de-aab9-8f8ad6b373d4

📥 Commits

Reviewing files that changed from the base of the PR and between d96d4d1 and 8fc2acb.

📒 Files selected for processing (6)

• .github/workflows/build_all.yml
• .github/workflows/build_linux.yml
• .github/workflows/build_macos.yml
• .github/workflows/build_windows.yml
• CMakeLists.txt
• ninja_build.sh

🚧 Files skipped from review as they are similar to previous changes (4)

• .github/workflows/build_macos.yml
• .github/workflows/build_windows.yml
• .github/workflows/build_all.yml
• .github/workflows/build_linux.yml