Add new accent colours replacing legacy ones - #33974
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (18)
🚧 Files skipped from review as they are similar to previous changes (17)
📝 WalkthroughWalkthroughUpdated theme selection to pass theme codes and high-contrast state through the preference and first-launch QML components. Reworked the accent color picker to use a two-row grid with explicit selection and bidirectional navigation. Adjusted related layouts and sizing. Updated accent color configuration values and the muse subproject reference. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/preferences/qml/MuseScore/Preferences/AccentColorsList.qml`:
- Around line 98-108: The AccentColorsList selection handler is emitting
requests on every checked-state transition instead of only on direct user
action. In AccentColorsList.qml, update the AccentColourButton logic that
currently uses onToggled alongside checked: root.currentColorIndex ===
colorIndex so the accentColorChangeRequested signal is emitted from onClicked
instead, keeping the request tied to a user click and avoiding stale emissions
when other buttons are programmatically unchecked.
- Around line 59-83: `AccentColorsList.qml` is computing `Grid.columns` as a
fractional value when the color list length is odd, which can break the two-row
layout and navigation logic. Update the `columns` binding in the `root` grid
setup to always return an integer, using `Math.floor(root.colors.length / 2)`,
and keep the existing `orderedColorIndices`, `navigationRowOf`, and
`navigationColumnOf` helpers aligned with that integer column count.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6eb7018b-ec8b-4245-bd18-a34b3f5d901f
📒 Files selected for processing (7)
musesandbox/web_sandbox/configs/dark.cfgsandbox/web_sandbox/configs/light.cfgsrc/app/configs/dark.cfgsrc/app/configs/light.cfgsrc/preferences/qml/MuseScore/Preferences/AccentColorsList.qmlsrc/preferences/qml/MuseScore/Preferences/internal/AccentColorsSection.qml
ajuncosa
marked this pull request as draft
June 26, 2026 13:30
ajuncosa
force-pushed
the
accent-colours
branch
4 times, most recently
from
July 2, 2026 10:59
feae2cd to
23a0754
Compare
ajuncosa
force-pushed
the
accent-colours
branch
3 times, most recently
from
July 8, 2026 10:51
572e079 to
fa65ef7
Compare
|
@ajuncosa checked one more time with fresher eyes, and it looks great. Let's merge it! |
ajuncosa
force-pushed
the
accent-colours
branch
from
August 7, 2026 05:48
fa65ef7 to
0142c98
Compare
ajuncosa
marked this pull request as ready for review
August 7, 2026 05:51
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/preferences/qml/MuseScore/Preferences/appearancepreferencesmodel.cpp`:
- Around line 49-59: Update AppearancePreferencesModel::setHighContrastEnabled()
to emit highContrastEnabledChanged() directly after writing the preference,
rather than relying on UiConfiguration::currentThemeChanged() or
setIsHighContrast() notifications. Preserve the existing state-change handling
in the currentThemeChanged callback.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: eba4b8c3-b1a2-4134-9df4-9d291a513b98
⛔ Files ignored due to path filters (1)
src/appshell/qml/MuseScore/AppShell/FirstLaunchSetup/resources/MuseSounds.pngis excluded by!**/*.png
📒 Files selected for processing (18)
musesandbox/web_sandbox/configs/dark.cfgsandbox/web_sandbox/configs/light.cfgsrc/app/configs/dark.cfgsrc/app/configs/light.cfgsrc/appshell/qml/MuseScore/AppShell/FirstLaunchSetup/FirstLaunchSetupDialog.qmlsrc/appshell/qml/MuseScore/AppShell/FirstLaunchSetup/ThemesPage.qmlsrc/appshell/qml/MuseScore/AppShell/FirstLaunchSetup/TutorialsPage.qmlsrc/appshell/qml/MuseScore/AppShell/FirstLaunchSetup/themespagemodel.cppsrc/appshell/qml/MuseScore/AppShell/FirstLaunchSetup/themespagemodel.hsrc/preferences/qml/MuseScore/Preferences/AccentColorsList.qmlsrc/preferences/qml/MuseScore/Preferences/AppearancePreferencesPage.qmlsrc/preferences/qml/MuseScore/Preferences/ThemeSamplesList.qmlsrc/preferences/qml/MuseScore/Preferences/appearancepreferencesmodel.cppsrc/preferences/qml/MuseScore/Preferences/appearancepreferencesmodel.hsrc/preferences/qml/MuseScore/Preferences/internal/AccentColorsSection.qmlsrc/preferences/qml/MuseScore/Preferences/internal/ThemeSample.qmlsrc/preferences/qml/MuseScore/Preferences/internal/ThemesSection.qml
🚧 Files skipped from review as they are similar to previous changes (6)
- src/appshell/qml/MuseScore/AppShell/FirstLaunchSetup/FirstLaunchSetupDialog.qml
- src/app/configs/light.cfg
- sandbox/web_sandbox/configs/light.cfg
- muse
- sandbox/web_sandbox/configs/dark.cfg
- src/app/configs/dark.cfg
…ew theme; Left align accent colours in Preferences
RomanPudashkin
approved these changes
Aug 7, 2026
ajuncosa
force-pushed
the
accent-colours
branch
from
August 7, 2026 07:22
0142c98 to
9d849b8
Compare
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #33863
Related to: musescore/muse_framework#109
Adds new accent colours to the light and dark themes, and displays them in two rows instead of one. This is updated in both the "Preferences" menu, as well as in the first slide of the "Getting started" first-launch dialog.