馃敄 Prepare v2.3.1 with Clang 23 linter support - #448
Conversation
Use the workflow-installed toolchain for versions newer than the cpp-linter action supports while preserving the existing behavior for older versions. Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
denialhaag
left a comment
There was a problem hiding this comment.
As discussed on Discord, this generally LGTM! We can use this to see what the linter says! 馃檪
Assisted-by: GPT-5.6 Sol via Codex
burgholzer
left a comment
There was a problem hiding this comment.
Based on the offline discussion.
LGTM after addressing the two comments.
Assisted-by: GPT-5.6 Sol via Codex
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Assisted-by: GPT-5.6 Sol via Codex
burgholzer
left a comment
There was a problem hiding this comment.
LGTM. Also directly prepared a release here. I'll let renovate run once more and then release 馃槍
馃 AI text below 馃
Description
This PR prepares the patch release
v2.3.1.It directly passes the LLVM installation directory prepared by
reusable-cpp-linter.ymltocpp-linter. The workflow already installs the requested Clang, clang-format, clang-tidy, and clang-tools packages before invokingcpp-linter-action. Pointing the action at/usr/lib/llvm-<version>/binmakes that installed toolchain authoritative and allows callers to select Clang 23 without version-specific workflow logic or changes to the existing input and default.This also bypasses the numeric-version limit in
cpp-linter-actionv2.21.0's bundledclang-tools1.2.0 resolver. That limit caused the jeff-mlir failure after LLVM 23 itself had installed successfully.AI assistance: GPT-5.6 Sol via Codex helped inspect the shared consumers, implement and validate the change, and prepare the release.
Validation
uvx prek run -agit diff --checkllvm.sh 23installed Clang 23.1.1, clang-format 23.1.1, and clang-tidy 23.1.1 under/usr/lib/llvm-23/binChecklist
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.I have added migration instructions to the upgrade guide (if needed).If PR contains AI-assisted content:
馃 *AI text below* 馃(titles are exempt).