Skip to content

💥 Complete QDMI migration - #2391

Merged
denialhaag merged 6 commits into
codex/backport-2249from
codex/backport-2115-2288-2368-2358-2349
Sep 5, 2026
Merged

💥 Complete QDMI migration#2391
denialhaag merged 6 commits into
codex/backport-2249from
codex/backport-2115-2288-2368-2358-2349

Conversation

@denialhaag

@denialhaag denialhaag commented Sep 4, 2026

Copy link
Copy Markdown
Member

Description

🤖 AI text below 🤖

Backports the following QDMI changes to v3.x:

These changes complete the FoMaC-to-QDMI naming migration, harden QDMI result handling, expose ordered shots from the DDSIM device, replace QDMI-specific Qiskit primitives with native primitives, raise the minimum Qiskit version to 2.1, submit PennyLane QDMI jobs concurrently, and document device selection for Slurm resources.

For #2288, this backport includes only the QDMI result handling that applies to v3.x. It retains the legacy circuit and OpenQASM surface and the DDSIM device's existing importer, without introducing an MLIR or LLVM dependency.

AI notice

This PR and its contents were created with the assistance of GPT-5.6 Sol via Codex.

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

burgholzer and others added 5 commits September 4, 2026 22:10
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
@denialhaag denialhaag self-assigned this Sep 4, 2026
@denialhaag denialhaag added refactor Anything related to code refactoring fix Fix for something that isn't working enhancement Improvement of existing feature minor Minor version update DD Anything related to the DD package Core Anything related to the Core library and IR c++ Anything related to C++ code python Anything related to Python code QDMI Anything related to QDMI backport Changes that have been backported to a stable release branch labels Sep 4, 2026
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.76271% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/qdmi/Client.cpp 60.0% 6 Missing ⚠️
include/mqt-core/qdmi/Client.hpp 93.7% 1 Missing ⚠️
python/mqt/core/plugins/pennylane/device.py 96.8% 1 Missing ⚠️
python/mqt/core/plugins/qiskit/job.py 98.5% 1 Missing ⚠️
src/dd/Simulation.cpp 94.4% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@denialhaag

Copy link
Copy Markdown
Member Author

@burgholzer, this is arguably the busiest PR and also needed a bit more care than more-or-less straightforward cherry-picking. Let me know if I should break this up further to make it easier to review!

@burgholzer burgholzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all the changes here. Looks pretty reasonable to me 🙌

@denialhaag
denialhaag merged commit b911dd5 into v3.x Sep 5, 2026
26 checks passed
@denialhaag
denialhaag deleted the codex/backport-2115-2288-2368-2358-2349 branch September 5, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Changes that have been backported to a stable release branch c++ Anything related to C++ code Core Anything related to the Core library and IR DD Anything related to the DD package enhancement Improvement of existing feature fix Fix for something that isn't working minor Minor version update python Anything related to Python code QDMI Anything related to QDMI refactor Anything related to code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants