feat(account): command handlers for account management (task 21) - #125
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
• Implement 6 command handlers: add, update, delete, validate, import, export
• Add domain ports: AccountValidator, AccountCredentialStore, PassphraseCodec
• Implement KeyringAccountStore and AesGcmPbkdf2Codec adapters
• Add 7 domain events for account operations
• Full test coverage: 91-97% handlers, 95% codec
Type
feat
Summary by cubic
Adds six account command handlers and crypto/keyring plumbing for full account management and encrypted import/export. Implements task 21 with atomic, cross‑platform‑safe exports and stronger rollback/cleanup on keyring failures.
New Features
AccountValidator(+ValidationOutcome),AccountCredentialStore,PassphraseCodec.KeyringAccountStore(per-account passwords),AesGcmPbkdf2Codec(AES‑256‑GCM + PBKDF2; header as AAD).account-added/updated/deleted/validated/validation-failed/accounts-imported/accounts-exported.aes-gcm,pbkdf2,hmac,rand.Bug Fixes
AccountDeletedalways fires.AccountValidationFailedfor transport/storage errors.created_atacross export/import so list ordering remains stable.Written for commit c0a8154. Summary will update on new commits. Review in cubic
Summary by CodeRabbit
New Features
Events
Documentation