Bug 2057561 - Caching derived scatter data (Fix 2) - #9750
Open
davidmiculit wants to merge 1 commit into
Open
Conversation
davidmiculit
requested review from
beatrice-acasandrei and
esanuandra
as code owners
August 3, 2026 10:38
✅ Deploy Preview for treeherder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
davidmiculit
force-pushed
the
feat/2057561-fix2
branch
from
August 3, 2026 10:52
8cdd3d7 to
808f816
Compare
esanuandra
reviewed
Aug 4, 2026
| return data.reduce((max, p) => (p.y > max ? p.y : max), data[0].y); | ||
| }; | ||
|
|
||
| _dataKey = (props) => { |
Collaborator
There was a problem hiding this comment.
why are they named with _ ?
Collaborator
|
There could be some stale-cache bugs, waiting on confirmation for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 2057561 - Improve frontend performance on Graphs View
componentDidUpdate runs flatMap/forEach/some/slice chains on every render, including hover/highlight changes.
Fix: Cache derived series in instance fields keyed by a shallow signature of inputs (testData length + visibility flags + timeRange). Only recompute when that signature changes. No need to refactor to hooks.
Before:
After:
