Skip to content

fix(midnight-sdk): route Midnight API defaults to v0#822

Merged
Rubilmax merged 1 commit into
mainfrom
hermes/midnight-api-v0-routes
Jul 7, 2026
Merged

fix(midnight-sdk): route Midnight API defaults to v0#822
Rubilmax merged 1 commit into
mainfrom
hermes/midnight-api-v0-routes

Conversation

@prd-carapulse

@prd-carapulse prd-carapulse Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Switch the Midnight API default base URL from https://api.morpho.org/v1/midnight to https://api.morpho.org/v0/midnight.
  • Update API tests to assert every default Books, quote, takeable-offer, and mempool validation route uses /v0/midnight.
  • Update JSDoc, TIB docs, and the pending Midnight SDK changeset so examples/docs point at the v0 route.

Test Plan

  • RED: updated MidnightApi route tests to expect /v0/midnight; observed failures while production still used /v1/midnight.
  • pnpm --filter @morpho-org/midnight-sdk test --run
  • pnpm --filter @morpho-org/midnight-sdk build
  • pnpm lint:ci
  • git diff --check
  • Independent pre-commit reviewer passed: no security concerns, no logic errors.

Request Context

  • Initiator: Romain / Slack: <@U03L0SC1JUR> / GitHub: unresolved
  • Initial Slack thread: channel C0B3LEQJQDA, thread 1782396593.698139
  • Additional context: User requested migrating v1 routes to v0 on the Midnight API in midnight-sdk, in code and examples.
  • Rationale: Keep the SDK default route and public examples aligned with the current Midnight API version.

Requested by: <@U03L0SC1JUR>


Open in Devin Review

@prd-carapulse prd-carapulse Bot requested a review from a team as a code owner June 25, 2026 14:21

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Rubilmax

This comment was marked as outdated.

@Rubilmax Rubilmax self-assigned this Jun 26, 2026
@prd-carapulse prd-carapulse Bot force-pushed the hermes/midnight-api-v0-routes branch from a20973f to 11c516c Compare July 7, 2026 12:28
@Rubilmax Rubilmax merged commit 6b906a0 into main Jul 7, 2026
10 of 11 checks passed
@Rubilmax Rubilmax deleted the hermes/midnight-api-v0-routes branch July 7, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants