fix: redact secrets from persisted operation records - #1601
Draft
leoxk wants to merge 1 commit into
Draft
Conversation
leoxk
force-pushed
the
codex/redact-komodo-secret-records
branch
2 times, most recently
from
August 21, 2026 11:42
7f63bd9 to
1423918
Compare
leoxk
force-pushed
the
codex/redact-komodo-secret-records
branch
from
August 21, 2026 12:02
1423918 to
8fa195a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Tests use only the synthetic marker
komodo-redaction-marker-4d9c1d48f7b84a9e. No production values or credentials were used.Added coverage for:
Local
git diff --checkpasses. A focused scan of the seven changed files found no credential-shaped literals; the only marker matches are the three intended synthetic tests. Rust and Docker tooling are not available in the local environment, so this Draft relies on upstream CI for formatting, compilation, and test execution. The upstream workflow currently requires maintainer approval for fork code and has run no jobs yet.Scope and limitations
is_secretmetadata, so detection is deliberately based on high-confidence key names: password/passwd, secret, token, credential(s), DSN, API key, private key, access key, and connection string.No deployment, migration, historical cleanup, or credential rotation is included.