feat(minifyx): replace Munee with pure-PHP pipeline for 2.0 - #9
Draft
Ibochkarev wants to merge 6 commits into
Draft
feat(minifyx): replace Munee with pure-PHP pipeline for 2.0#9Ibochkarev wants to merge 6 commits into
Ibochkarev wants to merge 6 commits into
Conversation
Drop the abandoned Munee stack in favor of a PSR-4 PHP 8.2 pipeline that keeps the MODX 2.8/3.x public API while adding hardened caching, image handling, CI, and regression tests.
Document MODX 2.8.x+ on PHP 7.4+ and MODX 3.x on PHP 8.2+, and enforce the matching floor during package install/upgrade.
- Protect empty CSS url() values and rebasing via MatthiasCssOptimizer - Add optional Terser/esbuild JS mangling with safe process runner and PHP fallback - Introduce AssetTag model, semantic BundlePlanner and opt-in preload hints - Replace Intervention Image with native GD/Imagick processors - Wire BuildRequest/BuildResult/BuildSignature in AssetPipeline - Extract RegisteredAssetPageProcessor; slim plugin to event adapter - Extend CI matrix to PHP 7.4 (prefer-lowest) through 8.4 Fixes #4 Fixes #7 Fixes #8
Move MinifyX facade to MinifyX\Model with global alias, harden getService entry points, add shared TestCase/phpstan-phpunit coverage, and apply PSR-12 plus 120-char line limits across src, model, tests, and lexicon.
Use the valid shivammathur/setup-php action so matrix jobs can start.
Add SRI/CORS injection, structured build errors, health check, import graph, source maps, warm-cache CLI, and security defaults. Bump to 3.0.0 with PHP 8.2+, MODX 3 service resolver, minifyx.php connector, settings migration, and CoffeeScript removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the abandoned Munee dependency with a pure-PHP asset pipeline for MinifyX 2.0. The snippet, plugin,
minify(), groups, hooks, and connector URL stay compatible with 1.x, but compilation, caching, and image handling now run on maintained PHP libraries without Node on production.Munee and its git submodule are removed. CSS/JS minification uses matthiasmullie/minify; SCSS/LESS use scssphp and wikimedia/less.php; images use Intervention Image v3. The facade delegates to a PSR-4
AssetPipelinewith atomic filesystem cache, fingerprinting, and sharedprocessFiles()for snippet and plugin paths.Platform requirements:
Security hardening closes path traversal (directory-boundary checks), cache filename injection, unbounded resize DoS (4096px cap), and no-op HMAC when a signing key is set. Failed compiles no longer write empty bundles. Post-hooks sync content before cache write; SCSS/LESS receive query-string variables; bundled registered assets keep first-tag attributes and drop SRI/crossorigin.
PHPUnit (24 tests) and PHPStan level 8 are included with GitHub Actions CI. See
core/components/minifyx/docs/migration-2.0.mdfor upgrade notes.