This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Repository navigation
RSS feeds, continued - #1225
Open
BasiqueEvangelist wants to merge 17 commits into
Open
RSS feeds, continued#1225BasiqueEvangelist wants to merge 17 commits into
BasiqueEvangelist wants to merge 17 commits into
Conversation
The current setup with the authorization token in the header isn't really optimal, so I'm removing the user notification feed from this PR, as a proper feed token impl requires changes on labrinth's side.
BasiqueEvangelist
marked this pull request as ready for review
October 3, 2023 20:38
Contributor
Author
|
Ready for review, just in case modrinth/labrinth#527 isn't accepted |
Member
|
would it be possible for you to fix merge conflicts |
Prospector
reviewed
Apr 14, 2024
| title: `${version.name}`, | ||
| id: `${projectUrl}/version/${version.id}`, | ||
| link: `${projectUrl}/version/${version.id}`, | ||
| description: `Loaders: ${loadersPretty}, Minecraft versions: ${gameVersionsPretty}`, |
Member
There was a problem hiding this comment.
if loadersPretty is comma-separated, shouldn't the separator between Loaders and MC versions be a semicolon? Tbh, not entirely sure this is the best description for these, but I am not entirely sure what is.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mineblock11 seems to have stopped working on #1159. This PR is a continuation of that PR, with some additional changes.
Just passing the token via a header feels like it wouldn't be implemented by many people, and putting the GitHub token in the path seems a bit worrying, especially if the URL gets leaked. Having a separate feed secret would be nicer, but that requires changes on labrinth.
The version items have their loaders and game versions as categories and the publisher is listed as the author, the project's team is listed in the feed, et cetera.
The most basic form of this is to link to them via
<link>elements, but showing off the feed visually would also be pretty nice.