Repository navigation
Conversation
Empty frames contribute to the merged dtype cache but are filtered out of partition concat. Cast remaining partitions so materialised data matches the cached schema (e.g. empty float64 + int64 -> float64), matching pandas. Signed-off-by: Eryx-Z <257642323+Eryx-Z@users.noreply.github.com>
Eryx-Z
requested review from
a team,
RehanSD,
YarShev,
anmyachev,
dchigarev,
devin-petersohn,
mvashishtha and
vnlitvinov
as code owners
October 16, 2026 20:31
Eryx-Z
force-pushed
the
fix/concat-empty-column-dtype-promotion
branch
from
October 16, 2026 20:31
762c7f1 to
12a0ea7
Compare
Author
|
Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When concatenating along rows, empty frames contribute to the merged dtype cache via
ModinDtypes.concatbut are filtered out of partition concat. The cached schema then disagrees with the materialised data (e.g. empty float64 + int64 reported as float64 while_to_pandas()stayed int64).Cast remaining partitions to the merged dtypes so materialised data matches the cache and pandas.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date