Skip to content

FIX-#7633: Support reset_index names without pandas fallback - #7700

Open
puneetdixit200 wants to merge 1 commit into
modin-project:mainfrom
puneetdixit200:fix-7633-reset-index-names
Open

FIX-#7633: Support reset_index names without pandas fallback#7700
puneetdixit200 wants to merge 1 commit into
modin-project:mainfrom
puneetdixit200:fix-7633-reset-index-names

Conversation

@puneetdixit200

Copy link
Copy Markdown

What do these changes do?

This implements native PandasQueryCompiler.reset_index() support for non-default names and allow_duplicates arguments instead of defaulting to pandas.

The implementation validates and derives pandas-compatible output columns on an empty frame, then keeps execution on the existing Modin from_labels() path. Regression coverage checks pandas parity and asserts that these cases do not emit the default-to-pandas warning.

AI assistance was used while drafting this patch; I reviewed the diff and verified the results below.

Targeted checks run:

  • MODIN_ENGINE=python pytest modin/tests/pandas/dataframe/test_indexing.py -q -k 'test_reset_index_with_names_and_allow_duplicates_does_not_default_to_pandas or test_reset_index_with_named_index'

  • black --check modin/core/storage_formats/pandas/query_compiler.py modin/tests/pandas/dataframe/test_indexing.py

  • flake8 modin/core/storage_formats/pandas/query_compiler.py modin/tests/pandas/dataframe/test_indexing.py

  • git diff --check

  • first commit message and PR title follow format outlined here

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py

  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py

  • signed commit with git commit -s

  • Resolves PandasOnRay doesn't implement reset_index for non-default names parameter #7633

  • tests added and passing

  • module layout described at docs/development/architecture.rst is up-to-date

…back

Signed-off-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PandasOnRay doesn't implement reset_index for non-default names parameter

1 participant