Docs UX audit + fix all 16 Medium findings#212
Merged
Conversation
Reader-experience audit (onboarding-weighted) of the docs site, README, architecture/ truth-home, and docstrings. 0 High, 16 Medium, 54 Low; every Medium adversarially verified. No fixes applied here — the report drives a follow-up fix plan. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bundle (design.md + plan.md) for fixing every Medium from the 2026-06-13 docs UX audit: runnable-example fixes, accuracy corrections, missing cross-links/sections, one nav split. Docs-only; no library code changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Read modern-di-litestar and modern-di-fastapi source: di_container is a named Litestar dependency (auto-resolves); setup_di merges lifespans and closes the container. Both fix tasks now carry exact edits. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…, O-2) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…lifespan reconciliation (O-3, D-21/X-4, O-6) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…tion example, missing-value section, cross-links, split advanced API page (D-1, O-4, X-1, D-11, X-3) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…eatorParameterError, fix scopes-example imports (X-2, A-3, O-7) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…mbered-step rendering across install sections (O-5, D-19) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ction (D-23, D-25) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lesnik512
added a commit
that referenced
this pull request
Jun 14, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A reader-experience audit of the documentation (onboarding-weighted), plus fixes for all 16 Medium-severity findings it produced. Complements the 2026-06-12 correctness audit by focusing on whether docs are convenient, understandable, readable, and consistent — and whether a brand-new user reaches first success quickly.
Audit
docs/,README.md,architecture/, and docstrings; every Medium adversarially verified.planning/audits/2026-06-13-docs-ux-audit-report.md.planning/changes/active/2026-06-13.01-docs-ux-audit/(audit) and2026-06-13.02-docs-ux-fixes/(this fix plan).Fixes (16 Mediums)
Onboarding path
index.mdQuickstart leads with a runnable sync example (the old async-only one never calledasyncio.run→ silent no-op).context.mdreordered to a manual-first Basic Usage, adds a "When no value is set" section (None vsArgumentResolutionError), and gains cross-links + See also.architecture/scopes.mdworked example: addGroupimport, useproviders.CacheSettings().Non-runnable / wrong examples
to-2.x.mdDict/List replacement now resolves (primitive fields supplied viakwargs).MyService/ALL_GROUPSdefined); confirmed againstmodern-di-litestarthatdi_containerauto-resolves by name.container.md"Explicit Injection" example actually uses the container + says when to prefer it.Accuracy / consistency
duplicate-type-error.mdcorrectedRuntimeError→DuplicateProviderTypeError(+ hierarchy note, cross-link).architecture/providers.mddocumentsUnsupportedCreatorParameterError(verified the trigger).from-that-depends.mdreconciles the two FastAPI wirings; confirmed viamodern-di-fastapithatsetup_dimerges lifespans and closes the container (so don't alsoasync with container).Migration / contributing / rendering
to-2.x.mdadds a.cast→ type-based-wiring/kwargs/ContextProvider migration recipe.contributing.mdfixes thegit clonecommand and adds a "Submitting changes" section (coverage gate, lint/test, planning convention).pytest.md+ the 4 integration pages (converted to numbered###headings, consistent withindex.md; the report'sindex.mdmention was a false positive — already headings). X-3 — splitcontainer.md's low-level API into a new Advanced / low-level API page and moved the context-propagation warning tocontext.md.Verification
uv run python(README, index, Dict/List, explicit-injection, exception hierarchy, scope wiring) — all pass.mkdocs build --strictpasses (exit 0, no broken-link/nav warnings).<ol start=1>; now single ordered list / clean headings.modern_di/code changed.The 54 Low findings are out of scope for this PR (listed in the report for a follow-up).
🤖 Generated with Claude Code