ci: move coverage flags into a test-ci recipe (match modern-di)#11
Merged
Conversation
Coverage flags lived in pytest addopts, so every pytest run — including a targeted `just test path -k name` — tripped --cov-fail-under=100. Mirror the core modern-di repo: empty addopts, a dedicated `test-ci` recipe carrying the coverage flags, an explicit `test-branch`, and CI runs `just test-ci`. The 100%% gate is still enforced in CI; targeted local runs no longer trip it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Aligns this repo's test/coverage setup with the core modern-di repo.
Before: coverage flags lived in
pytestaddopts(--cov=. --cov-report term-missing --cov-fail-under=100), so every pytest run — including a targetedjust test path -k name— tripped the 100% gate.After (matches modern-di):
addopts = ""— no implicit coverage on every run.test-cirecipe carries the coverage flags +--cov-fail-under=100; CI runsjust test-ci.test-branchmade explicit (--cov=. --cov-branch --cov-fail-under=100).just test [args]stays a plain, fast, gate-free runner.The 100% coverage gate is still enforced in CI (verified locally:
just test-cipasses at 100%); only targeted local runs stop tripping it.🤖 Generated with Claude Code