refactor: reuse save_model method#1443
Open
xiuyuan18 wants to merge 1 commit into
Open
Conversation
remove the duplicated implementaion of model saving in ModelLogger.on_epoch_end with already extract save_model
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the on_epoch_end method in diffsynth/diffusion/logger.py by replacing manual checkpoint saving logic with a call to a save_model helper method. This change improves code maintainability by reducing duplication. There are no review comments to address, and I have no further feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace the duplicated implementaion of model saving in
ModelLogger.on_epoch_endwith already existingModelLogger.save_modelmethod. The refactoring will improve the maintainability of the code.