Repository navigation
Give the impedances and resistances in Electrical parameters a unit - #4819
Open
henrikt-ma wants to merge 1 commit into
Open
henrikt-ma wants to merge 1 commit into
henrikt-ma wants to merge 1 commit into
Conversation
…ters a unit Inductances in the machine parameter records and several examples were computed as a number divided by 2*pi*f, where the number is a reactance in ohm, and some resistances were given as a number divided by a squared turns ratio. These numbers are now unitful literals in ohm, such as 0.3'Ohm'/(2*pi*fsNominal) and 0.04'Ohm'/turnsRatio^2, and the locked-rotor voltage of slip-ring machines is 100'V'*(...), so that the parameters have the units they are declared with. The values are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
henrikt-ma
added
L: Electrical.Analog
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar unit inconsistency fixes as in #4817, but for problems in
Electricalwhich are not exposed only becausepicarries a unit.