fix: handle cancellation for request id zero#2138
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 553b6b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
0d326bf to
a3d7042
Compare
Author
|
Rebased this on the latest
|
a3d7042 to
553b6b6
Compare
Author
|
Added the @modelcontextprotocol/core patch changeset and force-pushed 553b6b6. Local validation: changeset status shows @modelcontextprotocol/core patch; focused requestId 0 test passed; full core protocol.test.ts passed with 151 tests; core typecheck and lint passed; git diff --check passed. Pre-push typecheck, build, and lint also passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestId: 0when handlingnotifications/cancelled0Fixes #2115.
Validation
pnpm --filter @modelcontextprotocol/core exec vitest run test/shared/protocol.test.ts -t "notifications/cancelled behavior"pnpm --filter @modelcontextprotocol/core exec vitest run test/shared/protocol.test.tspnpm --filter @modelcontextprotocol/core run typecheckpnpm --filter @modelcontextprotocol/core run lintpnpm -r typecheck,pnpm -r build,pnpm sync:snippets --check,pnpm -r lintgit diff --check