fix(server): keep idle GET SSE streams alive#2124
Conversation
🦋 Changeset detectedLatest commit: 7f08da4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
|
This seems to be working in prod. Patched my own library with the changes and all good. |
|
Rebased onto current main, added the server patch changeset, and force-pushed 7f08da4. Local validation: changeset status shows @modelcontextprotocol/server patch; server streamableHttp.test.ts passed with 41 tests; server typecheck and lint passed; git diff --check passed. |
31e3308 to
7f08da4
Compare
|
Correction: the previous comment was posted after my first push attempt failed in the local pre-push hook with a transient pnpm workspace-state JSON parse error. I reran the push; pre-push typecheck, build, and lint all passed, and 7f08da4 is now pushed. |
Summary
Fixes #1211.
Validation
pnpm --filter @modelcontextprotocol/server exec vitest run test/server/streamableHttp.test.ts -t "keep-alive"pnpm --filter @modelcontextprotocol/server exec vitest run test/server/streamableHttp.test.tspnpm --filter @modelcontextprotocol/server run typecheckpnpm --filter @modelcontextprotocol/server run lintgit diff --check