Completely isolating Microsoft.Graph.Authentication solving dependency issues - #3789
Conversation
…endency issues ever again
|
Thank you Stephan van Rooij (@svrooij) , this is amazing restructuring to achieve full isolation. approving, passed on test build #3791 |
aed9bcd
into
microsoftgraph:main
|
A consideration for the release notes, since the PR description doesn't mention it: once the auth engine and its dependencies load into the private context, PowerShell scripts on PS7 can no longer reference the module's internal .NET types by name. Two common patterns break:
The Loader README documents this, but a breaking-change note would head off a wave of "type not found" issues. |
|
On time - so nice to see Stephan van Rooij (@svrooij) ! 🙏 |
Ramses Sanchez-Hernandez (@ramsessanchez) it seems people were using undocumented features that were possible because of the dlls leaking to the default assembly context. The exception might need a decent sample, shall I create a separate issue for the #securityhat -> Should the And then a |
|
Stephan van Rooij (@svrooij) thanks! I'd skip the connect-time opt-in though. It doesn't really protect anything, since code in the same session can already grab the token without touching any internal types: The realistic risk is a token landing in a log or a transcript, and a Two more things that might be worth a line in the notes:
🤖 Drafted and posted by Claude (Claude Code) on behalf of Mike Crowley (@Mike-Crowley). |
Changes proposed in this pull request
Other links