[http-client-csharp] Adopt Spector multiple-services scenario tests#10663
Open
JonathanCrd wants to merge 5 commits into
Open
[http-client-csharp] Adopt Spector multiple-services scenario tests#10663JonathanCrd wants to merge 5 commits into
JonathanCrd wants to merge 5 commits into
Conversation
- Update @azure-tools/azure-http-specs from 0.1.0-alpha.39 to 0.1.0-alpha.40-dev.12 to include the new service/multiple-services spec - Add service/multiple-services to the azure allow list in Spector-Helper.psm1 so the scenario is picked up during generation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Stubbed generation output for the service/multiple-services scenario, which defines two separate services (ServiceA and ServiceB) in a single TypeSpec file. The emitter correctly produces: - ServiceAClient with AOperations and ASubNamespace sub-clients - ServiceBClient with BOperations and BSubNamespace sub-clients Generated via: eng/scripts/Generate.ps1 -filter http/service/multiple-services Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add MultipleServicesTests covering all 4 operations: - ServiceA_OpA, ServiceA_SubOpA - ServiceB_OpB, ServiceB_SubOpB Tests are auto-skipped when code is stubbed. Verified all 4 pass with the full (non-stubbed) generator against the Spector mock API. Also adds the project reference to Spector.Tests.csproj. Resolves: Azure/azure-sdk-for-net#58453 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
emitter:client:csharp
commit: |
Contributor
|
No changes needing a change description found. |
Add the missing launch profile entry for the multiple-services scenario. This file is auto-generated by Generate.ps1 when run without a filter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JonathanCrd
changed the title
JonathanCrd
requested review from
JoshLove-msft,
ShivangiReja,
christothes,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
Contributor
|
No objections to including this in the unbranded test suite, but the actual issue was about including this for the Azure generator test suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Azure/azure-sdk-for-net#58453
This pull request adds a new test project for handling multiple services in the C# HTTP client generator, along with all necessary configuration and references. It also updates the development dependency on
@azure-tools/azure-http-specsto a newer version. The main focus is to introduce and test support for multiple service clients within the generated codebase.Addition of Multiple Services Test Project:
MultipleServicesTests.csto verify correct operation of multiple service clients and their sub-namespaces. [1] [2] [3] [4] [5]Dependency Updates:
@azure-tools/azure-http-specsdevelopment dependency from version0.1.0-alpha.39to0.1.0-alpha.40-dev.12in bothpackage.jsonandpackage-lock.json, along with associated peer dependency and engine requirement changes. [1] [2] [3]