Skip to content

feat(rallocator_cli): scroll long stack frames instead of wrapping #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martintmk wants to merge 3 commits into from
Closed

feat(rallocator_cli): scroll long stack frames instead of wrapping #667

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
030a40f
Scroll long stack frames instead of wrapping
martintmk Aug 13, 2026
632d7c1
fix: skip doctests for binary-only affected packages
martintmk Aug 13, 2026
400db8a
review: remove unrelated doctest recipe change
martintmk Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/rallocator_cli/src/templates/snapshot.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
.card{padding:18px}.metric{font-size:25px;font-weight:700;color:var(--accent)}.label{font-size:12px;color:var(--muted);text-transform:uppercase;letter-spacing:.08em}
section{padding:22px;margin:16px 0;overflow:auto}table{width:100%;border-collapse:collapse}th,td{padding:10px 12px;border-bottom:1px solid var(--line);text-align:right;white-space:nowrap}th:first-child,td:first-child{text-align:left}th{color:var(--muted);font-size:12px;text-transform:uppercase;letter-spacing:.05em}
.bar{height:8px;min-width:120px;background:#26314b;border-radius:9px;overflow:hidden}.bar>span{display:block;height:100%;background:linear-gradient(90deg,var(--accent),var(--good))}
code{color:#b9e8ff}ol{padding-left:24px}li{margin:14px 0}.stack{overflow-wrap:anywhere;color:var(--muted);font-family:ui-monospace,SFMono-Regular,Consolas,monospace;font-size:12px}
code{color:#b9e8ff}ol{padding-left:24px}li{margin:14px 0}.stack{overflow-x:auto;color:var(--muted);font-family:ui-monospace,SFMono-Regular,Consolas,monospace;font-size:12px;scrollbar-width:thin;scrollbar-color:#3b4969 transparent}.stack>div{white-space:nowrap}.hotspot-stacks>div{min-width:0}.stack::-webkit-scrollbar{height:9px}.stack::-webkit-scrollbar-track{background:transparent}.stack::-webkit-scrollbar-thumb{background:#3b4969;border-radius:5px}

@martintmk martintmk Sep 14, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted by an AI agent · Non-blocking

The stack-scroll change has no distinguishing regression test

Problem
The existing rendering fixtures check stack-details markup and exact symbol/source text, but are unchanged and never assert the new no-wrap, horizontal-scroll or hotspot shrink constraints. Reverting these declarations would leave those checks unchanged.

Why this matters
The new stack-display behavior can be removed or weakened without the existing rendering assertions noticing. This is a coverage gap, not an observed browser failure or lost baseline assertion.

Suggested fix
Extend the existing CLI rendering fixture with a long resolved frame, covering both retained stacks and paired hotspot stacks, and assert the emitted scrolling/no-wrap and column-shrink constraints through support::render_html. Keep this focused on the new output contract rather than adding a whole-report snapshot.

.region{display:grid;grid-template-columns:minmax(280px,520px) 1fr;gap:24px;align-items:start}.slice-map{width:100%;aspect-ratio:1;background:#090d18;border:1px solid var(--line);border-radius:8px;image-rendering:pixelated}
.slice-map .small{fill:#70d6ff}.slice-map .medium,.slice-map .medium-continuation{fill:#ffcf70}.slice-map .bump{fill:#72e0a8}.slice-map .unknown{fill:#7d879e}
.topology-owner .slice-map rect{fill:var(--owner-color)}.topology-owner .kind-legend,.topology-kind .owner-legend{display:none}
Expand Down
Loading