Extract shared state-aware normalization - #1091
Open
Gudge (MGudgin) wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Gudge (MGudgin)
pushed a commit
that referenced
this pull request
Sep 3, 2026
This PR updates the parser roadmap for the squashed Phase 7.2 implementation and its stacked pull request. Details * Record Phase 7.2 on the phase7b branch at 401ba0c. * Link PR #1091 and its Phase 7a base PR #969 in the status and delivery table. Tests * git diff --check Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 651084c2-3d1e-4824-917a-6994d62feba0
This PR changes state-aware parsing to produce one neutral wire input and run rolling and exact-contract requests through the same normalization seam. Details * Separates rolling source recovery from phase, policy, and telemetry normalization while preserving existing behavior and diagnostics. * Canonicalizes state-aware adapter inputs around the raw experimental payload and compares them with the real rolling pre-normalization representation. * Retains tested typed experimental mappings alongside raw payload transport, with provision-config parity coverage. Tests * `cargo fmt --all -- --check` * `cargo check --workspace --all-targets` * `cargo clippy --workspace --all-targets -- -D warnings` * `cargo test --workspace` Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 651084c2-3d1e-4824-917a-6994d62feba0
Gudge (MGudgin)
force-pushed
the
user/gudge/version_specific_config_parsers_phase7b
branch
from
September 3, 2026 16:46
401ba0c to
840f8c0
Compare
Gudge (MGudgin)
requested review from
a team
and
a balanced review from Copilot
September 3, 2026 16:46
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The architecture documentation incorrectly describes the current rolling and exact-contract normalization wiring.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
docs/state-aware-lifecycle/mxc-state-aware-sandbox-api.md — convert_wire_state_aware is not only the source adapter: it calls… |
|
docs/state-aware-lifecycle/mxc-state-aware-sandbox-api.md — The exact development adapter does not currently enter normalize_state_aware: it only returns… |
What changed in this PR
Extracts a neutral state-aware wire representation to prepare rolling and exact-contract parsers for shared normalization.
Changes:
- Separates rolling source recovery from state-aware normalization.
- Canonicalizes exact-contract adapter output and adds parity coverage.
- Updates lifecycle architecture documentation.
| File | Description |
|---|---|
config_parser.rs |
Extracts and tests shared normalization. |
dev/state_aware.rs |
Canonicalizes adapter output. |
state_aware_tests/common.rs |
Adds shared parity assertions. |
state_aware_tests/provision.rs |
Adds provision payload parity tests. |
state_aware_tests/start.rs |
Updates start parity tests. |
state_aware_tests/exec.rs |
Updates exec parity tests. |
state_aware_tests/stop.rs |
Updates stop parity tests. |
state_aware_tests/deprovision.rs |
Updates deprovision parity tests. |
dev/mod.rs |
Verifies experimental data canonicalization. |
mxc-state-aware-sandbox-api.md |
Documents the normalization architecture. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1135
to
+1137
| `convert_wire_state_aware` is now only the rolling source adapter. It extracts | ||
| and validates the raw experimental block, masks that block for base wire | ||
| deserialization, and produces: |
Comment on lines
+1149
to
+1151
| presence handling, and typed telemetry population. The exact development | ||
| adapter produces the same neutral representation and enters this seam without | ||
| duplicating rolling normalization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes state-aware parsing to produce one neutral wire input and run rolling and future exact-contract requests through the same normalization seam.
Details
Tests
cargo fmt --all -- --checkcargo check --workspace --all-targetscargo clippy --workspace --all-targets -- -D warningscargo test --workspaceMicrosoft Reviewers: Open in CodeFlow