Clarify ProcessContainer networking documentation - #1077
Closed
Branden Bonaby (bbonaby) wants to merge 2 commits into
Closed
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
8 tasks
microsoft-github-policy-service
Bot
added
the
Copilot-Instructions
Copilot started reviewing on behalf of
Branden Bonaby (bbonaby)
September 1, 2026 18:41
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
docs/process-container/examples/0.8.0-schema.md — This removes the inbound firewall authorization from the packaged AppContainer example, so the… |
|
docs/process-container/networking.md — The table now presents identity/isolation as the complete additional enforcement and drops the… |
What changed in this PR
Clarifies schema 0.8 ProcessContainer networking following #1076.
Changes:
- Documents native ingress enforcement and compatibility fallbacks.
- Updates proxy, WFP, and host-loopback behavior.
- Simplifies implementation terminology and examples.
| File | Description |
|---|---|
.github/copilot-instructions.md |
Updates ProcessContainer architecture guidance. |
docs/process-container/examples/0.8.0-schema.md |
Revises proxy manifest example. |
docs/process-container/networking.md |
Documents enforcement and fallback behavior. |
docs/process-container/os-version-support.md |
Updates runtime capability support matrix. |
docs/sandbox-policy/0.8.0/networking/networking.md |
Clarifies shared ProcessContainer semantics. |
docs/sandbox-policy/0.8.0/networking/schema-updates.md |
Clarifies 0.7-to-0.8 field mapping. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
65
to
+68
| xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10" | ||
| xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10" | ||
| xmlns:uap10="http://schemas.microsoft.com/appx/manifest/uap/windows10/10" | ||
| xmlns:desktop2="http://schemas.microsoft.com/appx/manifest/desktop/windows10/2" | ||
| xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities" | ||
| IgnorableNamespaces="uap uap10 desktop2 rescap"> | ||
| IgnorableNamespaces="uap uap10"> |
Copilot started reviewing on behalf of
Branden Bonaby (bbonaby)
September 1, 2026 18:46
View session
Negotiate ingress support, map capabilities and policy, integrate Learning Mode, and cover selection and fallback behavior with tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
Pre-existing issues (1)
| Severity | Finding |
|---|---|
|
docs/process-container/examples/0.8.0-schema.md — This removes the inbound firewall authorization from the packaged AppContainer example, so the… View comment |
Issues resolved since last review (1)
| Severity | Finding |
|---|---|
|
docs/process-container/networking.md — The table now presents identity/isolation as the complete additional enforcement and drops the… View resolved comment |
Document native enforcement, compatibility fallback, proxy requirements, and the temporary Windows Firewall requirement without exposing low-level OS contracts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Branden Bonaby (bbonaby)
force-pushed
the
user/bbonaby/update-mxc-based-on-os-network-changes
branch
from
September 1, 2026 18:51
433cda9 to
51f928e
Compare
Branden Bonaby (bbonaby)
force-pushed
the
user/bbonaby/process-container-network-docs
branch
from
September 1, 2026 18:51
d02f06b to
c561432
Compare
8 tasks
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Clarifies ProcessContainer networking behavior for schema 0.8.
Describes native enforcement, compatibility fallback, supported policy combinations, proxy requirements, and rejection behavior without exposing low-level OS contract details.
🔗 References
🔍 Validation
Documentation-only change.
✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See docs/pull-requests.md.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See docs/pull-requests.md
for the steps.