UefiTestingPkg: Correctly handle cached DMA audit ACPI tables - #938
Merged
Eeshan Londhe (eeshanl) merged 1 commit intoSep 15, 2026
Merged
Conversation
Contributor
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_plus/actions/runs/35010475228 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
mu-automation
Bot
added
the
impact:non-functional
Eeshan Londhe (eeshanl)
requested a review
from Michael Kubacki (makubacki)
September 11, 2026 22:08
Eeshan Londhe (eeshanl)
force-pushed
the
dmaprotectionacpi
branch
4 times, most recently
from
September 14, 2026 05:30
84e2539 to
a13e5bc
Compare
Eeshan Londhe (eeshanl)
changed the title
Eeshan Londhe (eeshanl)
force-pushed
the
dmaprotectionacpi
branch
from
September 14, 2026 07:26
a13e5bc to
59180a2
Compare
Michael Kubacki (makubacki)
approved these changes
Sep 14, 2026
Michael Kubacki (makubacki)
left a comment
Michael Kubacki (makubacki)
left a comment
Member
There was a problem hiding this comment.
Overall, looks fine now with the assert open remaining. Please wait for Intel system verification before merging.
Eeshan Londhe (eeshanl)
force-pushed
the
dmaprotectionacpi
branch
from
September 14, 2026 17:45
59180a2 to
487c082
Compare
Aaron (apop5)
approved these changes
Sep 15, 2026
Eeshan Londhe (eeshanl)
enabled auto-merge (squash)
September 15, 2026 18:45
Eeshan Londhe (eeshanl)
force-pushed
the
dmaprotectionacpi
branch
from
September 15, 2026 18:46
487c082 to
a7b48d9
Compare
Eeshan Londhe (eeshanl)
merged commit Sep 15, 2026
a8b711b
into
microsoft:release/202511
33 of 42 checks passed
5 tasks
Aaron (apop5)
pushed a commit
that referenced
this pull request
Sep 15, 2026
## Description Correctly handle cached DMA audit ACPI tables. Fixes #937 Tests call GetDmarAcpiTable(), but the Intel VT-d and IVRS implementation caches the ACPI table and returns EFI_ALREADY_STARTED on the second call without a reboot. GetAcpiTable() will no longer return already started and will always refresh the pointer with the data. On the caller side, the caching of the global variable is handled so we don't call GetAcpiTable() redundantly. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on Intel platform and all tests now pass. ## Integration Instructions N/A (cherry picked from commit a8b711b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correctly handle cached DMA audit ACPI tables. Fixes #937
Tests call GetDmarAcpiTable(), but the Intel VT-d and IVRS implementation caches the ACPI table and returns EFI_ALREADY_STARTED on the second call without a reboot.
GetAcpiTable() will no longer return already started and will always refresh the pointer with the data. On the caller side, the caching of the global variable is handled so we don't call GetAcpiTable() redundantly.
How This Was Tested
Tested on Intel platform and all tests now pass.
Integration Instructions
N/A