Skip to content

Rust Dependency: Update patina requirement from 22 to 23 - #935

Open
dependabot[bot] wants to merge 1 commit into
release/202511from
dependabot/cargo/patina-23
Open

Rust Dependency: Update patina requirement from 22 to 23#935
dependabot[bot] wants to merge 1 commit into
release/202511from
dependabot/cargo/patina-23

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 1, 2026

Copy link
Copy Markdown
Contributor

Updates the requirements on patina to permit the latest version.

Release notes

Sourced from patina's releases.

patina-v23.1.0

What's Changed

The minor version has been incremented in this release due to changes introduced in OpenDevicePartnership/patina#1705 that affect how certain public types may be used. Although these changes were made to address Clippy warnings and are not expected to alter behavior, the version increase is intended to highlight the API updates. If you encounter unexpected warnings or errors after upgrading, please refer to the latest crate documentation for current API details.


r_efi::efi is re-exported from patina::standard::efi, with the guidance that code should depend on the re-export.

While r-efi is only an explicit crate dependency of the patina crate today, it could inadvertently be added as a direct dependency of other crates in the repo in the future.

This change adds a deny rule to the deny.toml file to prevent direct dependencies on r-efi outside of the SDK crate.

This also allows tracking of transitive dependencies on r-efi.

Both patina and getrandom are allowed to depend on r-efi as getrandom does so today used as follows by patina_internal_core:

warning[unmatched-wrapper]: direct parent 'getrandom = 0.4.3' of
banned crate 'r-efi = 6.0.0' was not marked as a wrapper
    ┌─ deny.toml:146:16
    │
146 │     { crate = "r-efi", reason = "Depend on `patina` and use `patina::standard::efi` instead of r-efi directly.", wrappers = ["patina"] }
    │                ━━━━━             ───────────────────────────────────────────────────────────────────────────── reason
    │                │
    │                banned here
    │
    ├ r-efi v6.0.0
      └── getrandom v0.4.3
          └── rand v0.10.2
              └── (dev) patina_internal_core v23.0.2
                  └── patina_dxe_core v23.0.2
                      ├── (dev) patina_adv_logger v23.0.2

A small touchup to arch.rs is made to use the re-exported path.


Also includes a commit to remove a file referencing r_efi that is not included in the crate:

... (truncated)

Commits
  • c624699 Chore: Update crate versions to 23.1.0 (#1750)
  • 7e37c63 fv_read_section_efiapi: adjust data pointer (#1747)
  • ad3c5e5 Cargo.toml: No longer allow multiple_crate_versions
  • 6a585fa Update and integrate uart_16550 to 0.8
  • f097fb1 deny.toml: Ban direct dependecies on r-efi outside the SDK crate
  • 099c0f2 patina_internal_cpu: Delete orphaned file (cpu.rs)
  • a1f6643 Cargo.toml: Enable the pedantic clippy lint group
  • 3e11eed patina_dxe_core/runtime: Allow clippy::pedantic::linkedlist
  • c831106 patina_dxe_core/pecoff: Defer clippy::case_sensitive_file_extension_comparisons
  • 10af700 sdk/hob_list: Defer clippy::same_length_and_capacity
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added type:dependabot Created by dependabot type:dependencies Pull requests that update a dependency file labels Sep 1, 2026
@mu-automation

mu-automation Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

✅ QEMU Validation Passed

Source Dependencies

Repository Commit
mu_plus 7f1d4cb
mu_tiano_platforms af5ef34

Results

Platform Target Build Boot Overall Boot Time Build Logs Boot Logs
Q35 DEBUG ✅ success ✅ success 0m 18s Build Logs Boot Logs
ArmVirt DEBUG ✅ success ✅ success 0m 15s Build Logs Boot Logs

Workflow run: https://github.com/microsoft/mu_plus/actions/runs/33534081000

This comment was automatically generated by the Mu QEMU PR Validation workflow.

@makubacki

Copy link
Copy Markdown
Member

I'll push the manual updates needed to the PR.

@makubacki

Copy link
Copy Markdown
Member

I'll push the manual updates needed to the PR.

Done

@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/202511@d491bf0). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/202511     #935   +/-   ##
=================================================
  Coverage                  ?   10.20%           
=================================================
  Files                     ?      150           
  Lines                     ?    24583           
  Branches                  ?     2346           
=================================================
  Hits                      ?     2509           
  Misses                    ?    22038           
  Partials                  ?       36           
Flag Coverage Δ
AdvLoggerPkg 3.02% <ø> (?)
HidPkg 2.79% <ø> (?)
MfciPkg 34.00% <ø> (?)
MsCorePkg 1.30% <ø> (?)
MsWheaPkg 7.37% <ø> (?)
XmlSupportPkg 25.46% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Includes integration changes for path updates in the patina crate
that changed how GUID and protocols are exported.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:dependabot Created by dependabot type:dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants