fix(youtube): handle missing title metadata without raising AssertionError#2238
Open
hsusul wants to merge 1 commit into
Open
fix(youtube): handle missing title metadata without raising AssertionError#2238hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YouTubeConverter.convertfrom raisingAssertionErrorwhen converting YouTube HTML documents or streams that lack title metadata (title,og:title,name).<title>tag or empty string title.Problem
When
YouTubeConverter.convert()processes a YouTube page or stream that does not contain<meta name="title">or<meta property="og:title">tags (such as custom embeds or saved HTML pages),self._get(metadata, ["title", "og:title", "name"])returnsNone.An assertion immediately following this call (
assert isinstance(title, str)) caused an unhandledAssertionErrorto be raised, crashing the conversion of the document.Root cause
An invalid
assert isinstance(title, str)statement was executed directly on the result ofself._get(...)before checkingif title:. This prevented the converter from reaching its fallback logic at the end ofconvert().Fix
Removed the invalid assertion on
title. If no meta title tag is present,titleremainsNone,if title:cleanly skips appending the header, andtitlefalls back tosoup.title.stringor""at the end ofconvert().Testing
test_youtube_converter_missing_title_metadatatopackages/markitdown/tests/test_module_misc.py.AssertionErrorprior to the fix.pytest packages/markitdown/tests/test_module_misc.pypasses after the fix.Compatibility
Fully backward-compatible.