fix: handle PPTX SVG images without a rasterized fallback#2233
Merged
afourney merged 2 commits intoJul 23, 2026
Conversation
PowerPoint stores an SVG picture as an <a:blip> whose r:embed points to a
raster PNG fallback plus an <asvg:svgBlip> extension for the SVG. When a
picture has no raster fallback, the <a:blip> has no r:embed, so
python-pptx's shape.image raises ValueError("no embedded image"). This
caused PptxConverter to fail the entire conversion.
Resolve the SVG part directly from the svgBlip extension via a new
_get_image_info helper, and guard _is_picture against the exception
(hasattr only swallows AttributeError). Add unit tests plus a small
synthetic PPTX fixture covering the SVG-without-fallback case.
Contributor
Author
@microsoft-github-policy-service agree [company="Microsoft"] |
Contributor
Author
@microsoft-github-policy-service agree company=microsoft |
Contributor
Author
@microsoft-github-policy-service agree company=microsoft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PowerPoint stores an SVG picture as an <a:blip> whose r:embed points to a raster PNG fallback plus an asvg:svgBlip extension for the SVG. When a picture has no raster fallback, the <a:blip> has no r:embed, so python-pptx's shape.image raises ValueError("no embedded image"). This caused PptxConverter to fail the entire conversion.
Resolve the SVG part directly from the svgBlip extension via a new _get_image_info helper, and guard _is_picture against the exception (hasattr only swallows AttributeError). Add unit tests plus a small synthetic PPTX fixture covering the SVG-without-fallback case.