Upgrade to Java 17#552
Closed
vasiliy-mikhailov wants to merge 2 commits into
Closed
Conversation
Raise maven.compiler.release from 11 to 17 (and fix the malformed compiler source/target -> release), and bump the CI workflow JDKs to match. All 203 tests pass under JDK 17 with none lost.
Author
|
@microsoft-github-policy-service agree |
The project now targets Java 17 (maven.compiler.release=17), so building and CodeQL-analyzing at JDK 11 fails; fail-fast then cancels the 17 and 21 jobs. Test only 17 and 21.
Author
|
Closing this out — on reflection a standalone Java-version bump isn't really worth your review time without a clear benefit, and I didn't want to leave it sitting in your queue. Thanks for the work on this project. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the build from Java 11 to Java 17 (LTS).
pom.xml:maven.compiler.release11 → 17; themaven-compiler-plugin<source>/<target>were set to the literal{maven.compiler.release}(missing$, so not actually interpolated) — replaced with<release>17</release>.github/workflows/*(early_access, jreleaser, publish, release_to_github):java-version11 → 17 so CI/release build on the new targetVerification: the project compiles under JDK 17 and all 203 tests pass, with none lost versus the JDK-11 baseline. No production or test code was changed — only the compiler target and the CI JDK.
How this was produced
The compiler-target change was produced with OpenRewrite's
UpgradeJavaVersionrecipe:mvn -U org.openrewrite.maven:rewrite-maven-plugin:RELEASE:run \ -Drewrite.configLocation=$(pwd)/rewrite.yml \ -Drewrite.activeRecipes=com.example.UpgradeJava \ -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:RELEASEThe diff was then reduced by hand to the minimal compiler-target change, and the CI workflow
java-versionwas updated to match (OpenRewrite does not edit GitHub Actions).Verified: all 203 tests pass under JDK 17, none lost versus the baseline.