Repository navigation
[do not review] Fix type-scoped bounded date ranges - #6006
Draft
Mikael Weaver (mikaelweave) wants to merge 1 commit into
Draft
Mikael Weaver (mikaelweave) wants to merge 1 commit into
Mikael Weaver (mikaelweave) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Draft for Azure DevOps PR pipeline validation only; do not review or merge.
Fix
DateTimeBoundedRangeRewriterskipping bounded date-range searches when resource-column predicate pushdown wraps the date search parameter in anAndwith_type. Traverse conjunctive wrappers while retaining sibling predicates on both long-range and bounded short-range branches. Keep the existing rewriter order and skip disjunctions or conjunctions with multiple candidate date ranges.Add pipeline regression coverage for type-scoped/system searches with and without a reference chain, plus unit coverage for preserving
_typein both branches and excluding single bounds, multiple ranges, and disjunctions. No schema changes.Related issues
No linked GitHub issue.
Testing
dotnet test --project src\Microsoft.Health.Fhir.SqlServer.UnitTests --filter-class "*SqlServerSearchServiceTests" --filter-class "*DateTimeBoundedRangeRewriterTests": passed, 81/81.dotnet test --project src\Microsoft.Health.Fhir.SqlServer.UnitTests: failed, 1,253/1,254 passed; unchangedCustomQueriesUnitTests.GivenCustomQueryClass_WithGivenWaitTime_QueryToDBWillOccurOnlyAfterWaitPeriodexpected twoCreateCommand()calls but received one. Full-suite rerun produced the same failure.dotnet test --project src\Microsoft.Health.Fhir.SqlServer.UnitTests --filter-class "*CustomQueriesUnitTests": failed, 1/2 passed with the same call-count failure.git diff --check: passed.Azure DevOps PR validation is requested. Live SQL execution, continuation-token, sort,
_include, and SMART-scope end-to-end validation have not been run for this draft.FHIR Team Checklist
Semver Change (docs)
Patch