Skip to content

Fix delete by url - #5778

Merged
SergeyGaluzo merged 4 commits into
mainfrom
users/sergal/delete-by-url-2
Sep 1, 2026
Merged

Fix delete by url#5778
SergeyGaluzo merged 4 commits into
mainfrom
users/sergal/delete-by-url-2

Conversation

@SergeyGaluzo

@SergeyGaluzo SergeyGaluzo commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@SergeyGaluzo
SergeyGaluzo requested a review from a team as a code owner August 31, 2026 23:36
@SergeyGaluzo
SergeyGaluzo requested a balanced review from Copilot August 31, 2026 23:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes conditional URL deletion of SearchParameter resources so deletion completes through the reindex lifecycle.

Changes:

  • Handles soft deletes when no pending status exists in request context.
  • Reuses search-parameter deletion logic for hard deletes.
  • Adds E2E coverage for single and multi-URL deletion.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
DeletionService.cs Adds shared conditional search-parameter deletion handling.
ReindexTests.cs Verifies soft and hard URL deletions after reindex.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@LTA-Thinking Robert Johnson (LTA-Thinking) added Bug Bug bug bug. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs No-PaaS-breaking-change No-ADR ADR not needed labels Sep 1, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.25%. Comparing base (3a71c9e) to head (3e7f235).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5778      +/-   ##
==========================================
- Coverage   78.89%   78.25%   -0.64%     
==========================================
  Files        1016     1016              
  Lines       36856    36921      +65     
  Branches     5612     5614       +2     
==========================================
- Hits        29076    28893     -183     
- Misses       6404     6652     +248     
  Partials     1376     1376              

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SergeyGaluzo
SergeyGaluzo merged commit 72a3c1e into main Sep 1, 2026
48 checks passed
@SergeyGaluzo
SergeyGaluzo deleted the users/sergal/delete-by-url-2 branch September 1, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. No-ADR ADR not needed No-PaaS-breaking-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants