Fix non-inherited event handle causing wslrelay crash#40477
Open
Fix non-inherited event handle causing wslrelay crash#40477
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash risk when launching wslrelay.exe for WSLC port relay by ensuring the VM terminating event handle is actually inherited by the child process (instead of only being marked inheritable and passed as a numeric value on the command line).
Changes:
- Explicitly adds
m_vmTerminatingEventto theSubProcesshandle inheritance list when launchingwslrelay.exe.
benhillis
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change solves a potential crash that happens before
m_vmTerminatingEventisn't actually inherited by wslrelay, and if it's numeric value happens to collide with another handle that's in use by wslrelay.exe, this leads to undefined behavior, since that handle will get double-closed.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed